Improve error handling #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for #582 |
ineiti
requested changes
Oct 9, 2019
Gilthoniel
force-pushed
the
improve_error_handling
branch
from
6d94998
to
8af1d5b
Compare
|
Comments should be fixed. Also part of dedis/cothority#2061 |
ineiti
approved these changes
Oct 9, 2019
|
Good for me to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the errors to make use of the xerrors package. The
%vpolicy is respected except in case where the error is reused later for comparison.It also update the logger so that the file path replaces the function name to have precise location of the log and we can make use of the auto-resolution of the IDEs.
Note that
log.Errorwill print the complete stack trace if available. The formatting is left to the user for the other functions.