Reducing the size of the honeycomb traces #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first version sent information about GC and memory along every trace. As this information is quite heavy, it has been moved together with other information to AddStats, which is only called once per minute.
nkcr
approved these changes
Apr 14, 2020
|
I'm still confused if I should merge the PR now ;) 'Officially' I only have merge-rights on cothority. Should I still merge? Am I overcautious? |
|
good question, in my mind I was in the cothority mode but you're right, we haven't officially discuss the onet case ; ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first version sent information about GC and memory along every trace.
As this information is quite heavy, it has been moved together with other
information to AddStats, which is only called once per minute.
Reviewers: one OR another