Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE2] Migration Scala 3 #1742

Merged
merged 39 commits into from
Feb 25, 2024
Merged

[BE2] Migration Scala 3 #1742

merged 39 commits into from
Feb 25, 2024

Conversation

K1li4nL
Copy link
Contributor

@K1li4nL K1li4nL commented Feb 13, 2024

No description provided.

@github-actions GitHub Actions
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
pierluca
🥇		 4
▀▀▀▀▀		 5d 11h 55m
▀▀▀		 9
▀▀▀▀▀▀▀▀▀
jbsv
🥈		 2
▀▀▀		 7d 10h 45m
▀▀▀▀▀		 1
▀
MariemBaccari
🥉		 1
▀		 3d 54m
▀▀		 0
K1li4nL
 1
▀		 18m
 0

@K1li4nL K1li4nL marked this pull request as ready for review February 14, 2024 17:19
@K1li4nL K1li4nL requested a review from a team as a code owner February 14, 2024 17:19
@K1li4nL K1li4nL marked this pull request as draft February 14, 2024 17:23
@K1li4nL K1li4nL marked this pull request as ready for review February 15, 2024 14:09
pierluca
pierluca reviewed Feb 19, 2024
View reviewed changes
be2-scala/src/main/scala/ch/epfl/pop/pubsub/PublishSubscribe.scala Outdated
Comment on lines 126 to 133
case `broadcast` => portParamsWithMessage
case `publish` => portParamsWithMessage
case `subscribe` => portSubscribe
case `unsubscribe` => portUnsubscribe
case `catchup` => portCatchup
case `heartbeat` => portHeartbeat
case `get_messages_by_id` => portGetMessagesById
case `greet_server` => portGreetServer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there no better way than matching on actual text patterns ?
The previous approach was nice in that it avoided duplicated textual patterns across the codebase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this should be fixed now. I went over all the changes, hopefully none of these were left out.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues

Measures
0 Security Hotspots
65.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

pierluca
pierluca approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@pierluca pierluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to enable merging.
As discussed, there are still a few minor things that would benefit from a second pass.

@K1li4nL K1li4nL merged commit 2ede5cd into master Feb 25, 2024
18 checks passed
@K1li4nL K1li4nL deleted the work-be2-Kilian-Migration-Scala3 branch February 25, 2024 20:45
This was referenced Feb 25, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierluca pierluca pierluca approved these changes

Assignees
No one assigned
Labels
be2-scala
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@K1li4nL @pierluca