Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Disruption Protection overhaul #216

Merged
merged 48 commits into from
Jun 9, 2020
Merged

Disruption Protection overhaul #216

merged 48 commits into from
Jun 9, 2020

Conversation

lbarman
Copy link
Collaborator

@lbarman lbarman commented Oct 22, 2019

No description provided.

@coveralls
Copy link

coveralls commented Oct 22, 2019

Pull Request Test Coverage Report for Build 2313

  • 149 of 481 (30.98%) changed or added relevant lines in 9 files are covered.
  • 21 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-4.4%) to 69.877%

Changes Missing Coverage Covered Lines Changed/Added Lines %
prifi-lib/trustee/init.go 0 3 0.0%
prifi-lib/client/init.go 0 8 0.0%
prifi-lib/relay/init.go 0 16 0.0%
prifi-lib/trustee/disruption.go 0 20 0.0%
prifi-lib/client/disruption.go 0 23 0.0%
prifi-lib/relay/relay.go 73 114 64.04%
prifi-lib/client/client.go 75 122 61.48%
prifi-lib/dcnet/dcnet.go 1 74 1.35%
prifi-lib/relay/disruption.go 0 101 0.0%
Files with Coverage Reduction New Missed Lines %
prifi-lib/trustee/init.go 1 76.39%
prifi-lib/relay/disruption.go 3 0.0%
prifi-lib/client/client.go 6 69.69%
prifi-lib/relay/relay.go 11 74.13%
Totals Coverage Status
Change from base Build 2152: -4.4%
Covered Lines: 2851
Relevant Lines: 4080

💛 - Coveralls

helpers.lib.sh Outdated Show resolved Hide resolved
prifi-lib/client/client.go Outdated Show resolved Hide resolved
prifi-lib/client/client.go Outdated Show resolved Hide resolved
prifi-lib/client/client.go Outdated Show resolved Hide resolved
prifi-lib/client/client.go Outdated Show resolved Hide resolved
prifi-lib/client/client_test.go Outdated Show resolved Hide resolved
prifi-lib/relay/relay.go Outdated Show resolved Hide resolved
@@ -372,20 +373,23 @@ func (p *PriFiLibRelayInstance) upstreamPhase2b_extractPayload() error {

//disruption-protection
if p.relayState.DisruptionProtectionEnabled {
// Getting and checking the b_echo_last flag
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way this is the old protocol. Now the relay starts the blame when he gets the NIZKPoK, not b_echo

prifi.sh Outdated Show resolved Hide resolved
prifi.sh Outdated Show resolved Hide resolved
@lbarman lbarman changed the title Carlos villa Disruption Protection overhaul Oct 23, 2019
@lbarman
Copy link
Collaborator Author

lbarman commented Nov 30, 2019

LB->CV: I'm working on this PR this weekend, it will be easier to merge if you wait a little bit

@lbarman lbarman merged commit f5f1507 into master Jun 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants