Add dependency + docs for DateTime variable #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling 44b1f46 on datetime-variable into ** on master**. |
fgregg
requested changes
Jun 2, 2017
| @@ -229,6 +229,35 @@ the value is 0 or negative, then an exception will be raised. | |||
|
|
|||
| {'field' : 'cost', 'type': 'Price'} | |||
|
|
|||
| DateTime | |||
| ^^^^^^^^ | |||
There was a problem hiding this comment.
Give indication of what type of values date time can be.
fgregg
approved these changes
Jun 2, 2017
|
Changes Unknown when pulling 149bb7e on datetime-variable into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a dependency for
dedupe-variable-datetimetosetup.pyand updates the docs, in order to bring theDateTimefield type into dedupe core.(Also fixes a tiny little typo in the dedupe docs.)