Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for nearIntegersPredicate #595

Merged

Conversation

Leobouloc
Copy link
Contributor

@Leobouloc Leobouloc commented Jul 26, 2017

Fixes unexpected behavior with zero-padded integers.

Previously:

>>> dedupe.predicates.nearIntegersPredicate('abc 0091 cfd')
{'0091', '90', '92'}

With fix:

>>> dedupe.predicates.nearIntegersPredicate('abc 0091 cfd')
{'92', '90', '91'}

@coveralls
Copy link

coveralls commented Jul 26, 2017

Coverage Status

Coverage remained the same at 73.555% when pulling 830772f on eig-2017:fix_nearIntegersPredicate into 1b38234 on dedupeio:master.

@fgregg
Copy link
Contributor

fgregg commented Jul 26, 2017

Thank you!

@fgregg fgregg merged commit 9e10477 into dedupeio:master Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants