Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support of FILTER parameters with INTERSECTS #118

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

lgoltz
Copy link
Contributor

@lgoltz lgoltz commented Apr 24, 2024

This PR implements parts of OGC API - Features - Part 3. The implementation is not fully supporting the following requirements classes: "Queryables", "Queryables as Query Parameters", "Filter" with "CQL2 Functions", and "Features Filter".
Implementation is limited to S_INTERSECTS({spatialQueryable},{spatialInstance})

@lgoltz lgoltz added this to the 1.3.0 milestone Apr 24, 2024
@tfr42 tfr42 added the feature New feature request label Apr 24, 2024
@stephanr stephanr added the needs rebase PR is not up to date and needs rebase label Apr 24, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add source and license is missing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from OGC sources, https://portal.ogc.org/files/96288

Copy link
Member

@stephanr stephanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license header is missing for the new Java files in the package org.deegree.services.oaf.cql2.

Also, it is not clear to me if the added grammar file cql2.g4 is also required to have a license header.

@dstenger dstenger removed the needs rebase PR is not up to date and needs rebase label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants