Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes metadata links in collections view (HTML encoding) #43

Conversation

tfr42
Copy link
Member

@tfr42 tfr42 commented Jun 28, 2022

This PR fixes the HTML collections view for linked metadata

@tfr42 tfr42 added the enhancement Improvement of existing feature or function label Jun 28, 2022
@copierrj
Copy link
Member

The TMC (without @tfr42 being present) discussed this PR and we are hesitant to merge this as we do not understand why the title of the collection is being used here. Is 'title' always present and is it guaranteed to be unique?

@tfr42
Copy link
Member Author

tfr42 commented Jul 27, 2022

Indeed the title is not unique but it is unlikely that a user configures two or more collections with the same title within a dataset. In case a configuration contains two or more collections with the same title the HTML view will show then the metadata link for all collections. But it will not break the view or result in an error.
Nevertheless it is possible to change the implementation to use the collection ID instead but would require changes on the server-side (java code) as well.

@tfr42
Copy link
Member Author

tfr42 commented Jul 27, 2022

@copierrj copierrj merged commit 2cd140d into deegree:main Oct 5, 2022
@tfr42 tfr42 added this to the 1.3.0 milestone Dec 17, 2022
@tfr42 tfr42 deleted the fixMultipleMetadataLinksInCollectionsHtml-8271 branch November 15, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature or function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants