Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies to Servlet 6.0 and Faces 4.0 (Jakarta EE 10) #1627

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

tfr42
Copy link
Member

@tfr42 tfr42 commented Jan 10, 2024

This PR upgrades the dependencies from javax. to jakarta. modules for Servlet API and Faces API.
To fit the new API also Apache commons-fileupload #1625 is migrated to Apache commons-fileupload2 for Servlet 6.0 and a workaround for the incompatible reflection API #1624 is added.

@tfr42 tfr42 added console deegree administration console dependencies Pull requests that update a dependency (library) core deegree core modules labels Jan 10, 2024
@tfr42 tfr42 added this to the 3.6 milestone Jan 10, 2024
@tfr42 tfr42 self-assigned this Jan 25, 2024
pom.xml Show resolved Hide resolved
Copy link
Member

@stephanr stephanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, the PR looks fine

deegree-tests/pom.xml Show resolved Hide resolved
@stephanr stephanr merged commit 39c7bba into deegree:main Feb 7, 2024
1 check passed
@tfr42 tfr42 deleted the feature/migrateToServlet6.0-1401 branch February 25, 2024 09:58
@tfr42
Copy link
Member Author

tfr42 commented Jun 13, 2024

For deegree 3.6 the console was migrated to Faces 4.0 using CDI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console deegree administration console core deegree core modules dependencies Pull requests that update a dependency (library)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to commons-fileupload2-jakarta-servlet6 required Add support for Tomcat 10.0 and 10.1
3 participants