Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support service metadata files in subdirectories #303

Conversation

MrSnyder
Copy link
Contributor

Consider a deegree INSPIRE workspace with several WMS and WFS instances:

  • workspaces/inspire/services/inspire/ad/wfs.xml
  • workspaces/inspire/services/inspire/ad/wfs_metadata.xml
  • workspaces/inspire/services/inspire/ad/wms.xml
  • workspaces/inspire/services/inspire/ad/wms_metadata.xml
  • workspaces/inspire/services/inspire/cp/wfs.xml
  • workspaces/inspire/services/inspire/cp/wfs_metadata.xml
  • workspaces/inspire/services/inspire/cp/wms.xml
  • workspaces/inspire/services/inspire/cp/wms_metadata.xml

In the use-cas, it is important to have separate services for each inspire theme. For WMS, the GetCapabilities request returns a document with the data from the correct wms_metadata.xml. The problem is that for WFS it does not seem to use the wfs_metadata.xml from the corresponding directory. The WFS GetCapabilities document contains some default values for metadata.

Currently, when a wfs_metadata.xml is put in the directory workspaces/inspire/services/, that file is picked up by both AD and CP WFS capabilities. This patch fixes that behavior.

Note that a patch for 3.4 is not required, as this already works as expected. This is an effect of the workspace reimplementation.

…les for service configs in subdirs are found.
MrSnyder added a commit that referenced this pull request Jun 6, 2014
…ta-in-subdirs

Support service metadata files in subdirectories
@MrSnyder MrSnyder merged commit 716ac28 into deegree:3.3-master Jun 6, 2014
@MrSnyder MrSnyder deleted the 3.3-enhancement-service-metadata-in-subdirs branch June 6, 2014 13:31
@tfr42 tfr42 added this to the 3.3.10 milestone Jun 26, 2014
@tfr42
Copy link
Member

tfr42 commented Jun 26, 2014

Thank you for your contribution. Your pull requests has been accepted by the TMC. Please find more information in the meeting chat available at http://wiki.deegree.org/deegreeWiki/TmcMeeting/TmcMeeting20140606.
This pull request will be part of the 3.3.10 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants