Fix RPS LJE and update documentation #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lems in benchmark
lucashervier
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RPS LJE and update documentation
Although it provided satisfactory results in the CIFAR10 benchmark, the implementation of RPS LJE didn't actually follow the description in the paper. This is fixed in 55bffb1 . An abstraction is also implemented to simplify the shared code between RPS L2 and RPS LJE in c28abb6 .
The tests were adjusted to follow the current implementation.
I was forced to opt for a less optimized version in 727e5e4 without end-to-end lazy computations for the estimation of the hessian as it led to cuBLAS errors when applying the pinv operation.
#21 is also fixed by removing the abstract method without the actual implementation in dev@f1a360f
More thorough documentation was added throughout and more notebooks are included in the README.