Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mahalanobis and RMDS methods #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Mahalanobis and RMDS methods #93

wants to merge 2 commits into from

Conversation

cofri
Copy link
Contributor

@cofri cofri commented Apr 29, 2024 •
edited
Loading

Two bugs are fixed:

  • Mahalanobis: the mean covariance for all classes is now correctly computed based on the total number of inputs len(features[0]) and not len(features) which is a list of 1 element.
  • RMDS: the formula for the score is $MD_k - MD_0$

@cofri
fix(Mahalanobis): mean covariance computation
2fd39ba 
len(features) is a list and here equals 1.
Expected value is: len(features[0])
@cofri
fix(RMDS): sign error fixed
c13da98
@github-actions GitHub Actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
2334 2160 93% 70% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
oodeel/methods/mahalanobis.py 98% 🟢
oodeel/methods/rmds.py 97% 🟢
TOTAL 98% 🟢

updated for commit: c13da98 by action🐍

@cofri cofri requested review from jdalch and y-prudent April 29, 2024 07:04
@cofri cofri marked this pull request as ready for review April 29, 2024 07:04
jdalch
jdalch reviewed Apr 29, 2024
View reviewed changes
Copy link
Contributor

@jdalch jdalch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdalch jdalch jdalch left review comments

@y-prudent y-prudent Awaiting requested review from y-prudent

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cofri @jdalch