Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Causal fidelity for tabular #91

Merged
merged 3 commits into from Feb 7, 2022
Merged

Causal fidelity for tabular #91

merged 3 commits into from Feb 7, 2022

Conversation

DavidPetiteau
Copy link
Collaborator

Add causal fidelity metrics for tabular data

The subject of this pull request is to add causal fidelity metrics for tabular data (deletion and insertion):

Other contribution

  • Correct xplique/plots/tabular.py to avoid warnings b193084

lucashervier
lucashervier requested changes Jan 28, 2022
View reviewed changes
Copy link
Collaborator

@lucashervier lucashervier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the intuition that the "Tab" metrics could simply inherits from the "TS" metrics. Therefore, it would save a great deal of files. Do you think its doable ?

This was linked to issues Jan 28, 2022
Fidelity Metrics with tabular values #72
Closed
Warning appearing while calling some tabular visualization functions #87
Closed
@lucashervier lucashervier added the bug Something isn't working label Jan 28, 2022
fel-thomas
fel-thomas requested changes Jan 31, 2022
View reviewed changes
Copy link
Member

@fel-thomas fel-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first PR for david! some small changes / things to check that I put in comment. Also you should fix your commits and let's go for merge ;)

xplique/metrics/fidelity.py Outdated Show resolved Hide resolved
xplique/metrics/fidelity.py Show resolved Hide resolved
xplique/plots/tabular.py Show resolved Hide resolved
@DavidPetiteau
Copy link
Collaborator Author

that's all for the commits.

@fel-thomas
Copy link
Member

LGTM !

@fel-thomas fel-thomas self-requested a review February 2, 2022 18:01
@fel-thomas fel-thomas merged commit d4dc3d3 into develop Feb 7, 2022
@fel-thomas fel-thomas deleted the david branch February 7, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fel-thomas fel-thomas fel-thomas approved these changes

@lucashervier lucashervier lucashervier approved these changes

@AntoninPoche AntoninPoche Awaiting requested review from AntoninPoche

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Go to the first Tagged Version 🚀
Development

Successfully merging this pull request may close these issues.

Warning appearing while calling some tabular visualization functions Fidelity Metrics with tabular values
3 participants
@DavidPetiteau @fel-thomas @lucashervier