AverageStability metric: ensure noisy masks applied use radius parameter #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fel-thomas
requested review from
lucashervier,
DavidPetiteau and
AntoninPoche
fel-thomas
force-pushed
the
stability-radius
branch
from
0555a2e
to
c6dd804
Compare
AntoninPoche
approved these changes
Jan 18, 2022
DavidPetiteau
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DavidPetiteau and David V. identified a problem in the stability metric
AverageStability: the radius is fixed and the parameter is not used. This RP fixes this problem and introduces a test to avoid this in the future.