Add plots for metrics and timeseries #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucashervier
requested changes
Jan 27, 2022
fel-thomas
requested changes
Jan 31, 2022
There was a problem hiding this comment.
I can't wait to see this feature merged! We should make a notebook with it, congratulations Antonin! 🎉
Some minor changes in line with @lucashervier, nothing major ;)
fel-thomas
force-pushed
the
antonin/dev
branch
from
fe2498a
to
9e52e0d
Compare
fel-thomas
approved these changes
Feb 3, 2022
AntoninPoche
force-pushed
the
antonin/dev
branch
from
9e52e0d
to
be8ff60
Compare
AntoninPoche
changed the title
|
The remarks from Lucas has been taken into account. I hope this is better ! I just have a pylint check that does not pass, but it does not seems to come from my code but from the checking (impossible to load keras issue). |
|
Even better, I approved 2 days ago, I agree for Pylint I made fix the issue in David's PR that should be merge as soon as someone approve (I already approved it) 👍 |
lucashervier
approved these changes
Feb 7, 2022
fel-thomas
force-pushed
the
antonin/dev
branch
from
be8ff60
to
c2c2593
Compare
This was
linked to
issues
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plots for metrics and timeseries
For metrics, the plots are added in 996fad3 and tested in d755524.
For timeseries, the plots are added in 70ded0d and tested in be8ff60.
Metrics
Those are two plots that I often use. I though they may need to be integrated in Xplique.
I also made is so that each method can be assign a color and match between both plots.
Metrics histograms
This one to compare the attribution methods through several metrics:
Fidelity curves
This plot show the evolution of the score depending on the number of features perturbed. It is also used to compare methods. It can easily be done thank to the
detailed_evaluate()method ofCausalFidelityandCausalFidelityintroduced in pull request #70.Note that the lines on this plot are just here for testing the function.
Timeseries
The following plots come from the same function, they both output heatmaps. But for the first, a numpy array is given while the second receives a dictionary of numpy arrays.
One explanation heatmap
Several explanations heatmaps
This plot should adapt the arrangement of the subplots based on the heatmap shape and their number.
