Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeError: init_logger() got an unexpected keyword argument 'pre_hooks' #98

Closed
prasannababuAddagiri opened this issue Sep 17, 2019 · 6 comments
Closed

TypeError: init_logger() got an unexpected keyword argument 'pre_hooks' #98

prasannababuAddagiri opened this issue Sep 17, 2019 · 6 comments
Assignees
@jaswanth098
Labels
bug-type inprogress-status

Comments

@prasannababuAddagiri
Copy link

  • we got the below issue when ran the sample hello_world.py which is in README
  • TypeError: init_logger() got an unexpected keyword argument 'pre_hooks'
    image
  • basescript version(0.3.3)
    image
@jaswanth098 jaswanth098 self-assigned this Sep 17, 2019
@jaswanth098
Copy link
Contributor

@prashanthellina pre_hooks and post_hooks support has been removed was this intentional?
Ref: https://github.com/deep-compute/basescript/pull/94/files#diff-dc82fce42548e16e9b4331cd2c343753R361

@prashanthellina
Copy link
Member

My bad. I did want to replace pre_hooks and post_hooks by just processors but looks like I missed testing this aspect of it (i.e. I tested only calling init_logger directly). Will fix this today.

prashanthellina added a commit that referenced this issue Sep 18, 2019
@prashanthellina
references #98, fixed the issue and tested the hello world example wo…
1fda354 
…rks as expected
@prashanthellina prashanthellina mentioned this issue Sep 18, 2019
Merged
@prashanthellina
Copy link
Member

@jaswanth098 Applied the fix. Please review, merge and release.

jaswanth098 added a commit that referenced this issue Sep 18, 2019
@jaswanth098
Merge pull request #99 from deep-compute/bugfix-hooks-to-processors
891a3a7 
references #98, fixed the issue and tested the hello world example wo…
@prashanthellina
Copy link
Member

@prasannababuAddagiri : @jaswanth098 made a release with the fix. Can you please take the latest version and try again?

@jaswanth098
Copy link
Contributor

@prasannababuAddagiri This has been fixed and pushed to PyPi, please check this out with the latest version
Closing this as this is fixed, feel free to open this issue if needed

@prasannababuAddagiri
Copy link
Author

sure @prashanthellina @jaswanth098. will test now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaswanth098 jaswanth098

Labels
bug-type inprogress-status
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@prashanthellina @jaswanth098 @prasannababuAddagiri