references #68, basescript is now a command-line tool which supports … #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a 'pretty' sub-command that can be used to view json format logs in pretty format
basescript/basescript.py
Outdated
| @@ -182,3 +193,10 @@ def run(self): | |||
| Override this method to define logic for `run` sub-command | |||
| """ | |||
| pass | |||
|
|
|||
| def pretty(self): | |||
| print("hello") | |||
There was a problem hiding this comment.
Is this a dummy definition? Then I think we should use pass instead of a print statement
There was a problem hiding this comment.
Thanks for catching that. I had initially thought of the writing the sub-command implementation in that function but later decided to do inside pretty_print from log module. Removed it now in the latest commit.
ManishaBayya
approved these changes
Jul 6, 2021
shivam05011996
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…a 'pretty' sub-command that can be used to view json format logs in pretty format
references #68