Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setup.py #27

Closed
wants to merge 2 commits into from
Closed

Fix setup.py #27

wants to merge 2 commits into from

Conversation

cifkao
Copy link

@cifkao cifkao commented Mar 30, 2022

  • Avoid importing the package in setup.py to get its version (this will fail if dependencies are not installed). See this.
  • Use setuptools instead of distutils to make dependencies work (distutils doesn't actually support install_requires and python_requires).

@cifkao cifkao mentioned this pull request Mar 30, 2022
Closed
@cifkao
Copy link
Author

cifkao commented Mar 30, 2022

(#25 already solves the first problem in a different way.)

@bpopeters
Copy link
Collaborator

Fixed via #25.

@bpopeters bpopeters closed this Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cifkao @bpopeters