Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherrypick dark-mode changes #1

Closed
deepakjois opened this issue Oct 20, 2017 · 2 comments
Closed

Cherrypick dark-mode changes #1

deepakjois opened this issue Oct 20, 2017 · 2 comments

Comments

@deepakjois
Copy link
Owner

deepakjois commented Oct 20, 2017

@Steve2955 Here is a commit in my fork which cleans up your patch and just retains the essential changes: 82ffcc6

I don’t want to claim credit for your patch, so it is best if you cherry pick in your code. Here is a list of steps you could follow, if you are having difficulty with Git.

First, add my repo to your remote:

git remote add dj https://github.com/deepakjois/writing

Then reset your master branch to the base commit in the original repo, and cherry-pick my changes (without committing them). and then commit them under your name:

git reset --hard 7045bfbefa63a5540c0dbbb502e488e600f745da
git cherry-pick --no-commit  dj/master
git add .
git commit -m "Enable dark mode changes"

Then do a force push to your remote repo, and the pull request will be automatically updated:

git push -f origin master
@deepakjois
Copy link
Owner Author

If you are still having trouble, please add me as a collaborator to your repo and I will commit it directly there with you as the author.

@Steve2955
Copy link

Thank you so much for your help. This is the first time I'm contributing to an open source project and I didn't expect that much kind support. I will probably do this more often in the future, I really enjoy it so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants