Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposed unified code formatting #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tomasz-lewicki
Copy link
Collaborator

Hey All,

I don't wanna play any formatting sheriff here, but we are running into some issues (see f7f391e ).

We have 2 space vs 4 space indent mixed, and later they can occur as changes if we edit file using a different editor. How about we stick to one format?

We could, for example use a formatting tool to adhere to one format (google style guide in this case):

clang-format -style=google command.c > command_formatted.c

This PR is just to show how it would work on one file. Let me know what you think!

@leehj825
Copy link
Collaborator

leehj825 commented Apr 4, 2020

This is a good idea. I agree to stick to one format. I will fix the format as I update each file.

@deepaktalwardt
Copy link
Owner

Yeah, I think this is a good idea. Is everyone okay with Google's format though? I really prefer WebKit format. But I'm okay with whatever you guys prefer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants