Skip to content

Commit

Permalink
Oss (#190)
Browse files Browse the repository at this point in the history
* changed to run on Github Infra

* Removed Chores CI

* fixie fix removed badges not working fun fun
  • Loading branch information
DanArlowski committed Nov 28, 2021
1 parent 9ff8401 commit 316688e
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 51 deletions.
44 changes: 1 addition & 43 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,9 @@ on:

jobs:
tests:
runs-on: ${{ matrix.os }}
runs-on: ubuntu-latest
strategy:
matrix:
os: [self-hosted]
python-version: ["3.6", "3.7", "3.8", "3.9"] #TODO: add 3.10 when scikit-learn have a wheel https://github.com/scikit-learn/scikit-learn/pull/21232

steps:
Expand All @@ -24,44 +23,3 @@ jobs:
run: make env
- name: Run Tests
run: make test

chores:
runs-on: [self-hosted]

needs: tests
if: ${{ github.ref == 'refs/heads/main' }}

steps:
- uses: actions/checkout@v2
- name: Set up Python 3.9
uses: actions/setup-python@v2
with:
python-version: 3.9
- name: Run Code Coverage
id: coverage
run: |
make coverage
COVERAGE=$(cat .cover.log | grep TOTAL | tr -s ' ' | cut -d ' ' -f4 | tr -dc '0-9' )
echo "::set-output name=code_coverage::$COVERAGE"
- name: Validate Code Style
id: validate
run: |
PYLINT=$(make validate | sed -n 's/^Your code has been rated at \([-0-9.]*\)\/.*/\1/p')
echo "::set-output name=pylint_score::$PYLINT"
- name: Generate & Publish Badges
run: |
pip install anybadge awscli
# generate code-coverage badge
anybadge -s "%" -l coverage -v ${{ steps.coverage.outputs.code_coverage }} -f coverage.svg coverage
# generate pylint-score badge
anybadge -l pylint -v ${{ steps.validate.outputs.pylint_score }} -f pylint.svg pylint
#Upload to S3
aws s3 cp pylint.svg s3://deepchecks-public/mlchecks/pylint.svg
aws s3 cp coverage.svg s3://deepchecks-public/mlchecks/coverage.svg
env:
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
4 changes: 2 additions & 2 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
pylint:
runs-on: [self-hosted]
runs-on: ubuntu-latest


steps:
Expand All @@ -34,7 +34,7 @@ jobs:
run: make docstring

notebook:
runs-on: [self-hosted]
runs-on: ubuntu-latest

needs: pylint #rather consuming task, run only after linting succeed

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:
jobs:
labels:
name: Validate Label
runs-on: [self-hosted]
runs-on: ubuntu-latest

steps:
- uses: mheap/github-action-required-labels@v1
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ on:
- "[0-9]+.[0-9]+.[0-9]+"

jobs:
Create:
runs-on: [self-hosted]
Create-Release:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
Expand Down
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@
![pkgVersion](https://img.shields.io/pypi/v/deepchecks)
![build](https://github.com/deepchecks/deepchecks/actions/workflows/build.yml/badge.svg)

[comment]: <> "![coverage](https://deepchecks-public.s3.eu-west-1.amazonaws.com/deepchecks/coverage.svg)"
[comment]: <> "![pylint](https://deepchecks-public.s3.eu-west-1.amazonaws.com/deepchecks/pylint.svg)"

Deepchecks is a Python package for comprehensively validating your machine learning
models and data with minimal effort.
This includes checks related to various types of issues, such as model performance,
Expand Down

0 comments on commit 316688e

Please sign in to comment.