moving new label check to the classification suite (#241)

* moving new label check to the classification suite
deepchecks · Dec 9, 2021 · 44aa334 · 44aa334
1 parent 78ac7a4
commit 44aa334
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 7 deletions.
diff --git a/deepchecks/checks/performance/segment_performance.py b/deepchecks/checks/performance/segment_performance.py
@@ -81,7 +81,7 @@ def run(self, dataset, model) -> CheckResult:
             if self.feature_1 is None and self.feature_2 is None:
                 feature_importance = calculate_feature_importance(dataset=dataset, model=model)
                 if len(feature_importance) < 2:
-                    raise DeepchecksValueError('Must have atleast 2 features')
+                    raise DeepchecksValueError('Must have at least 2 features')
                 feature_importance.sort_values(ascending=False, inplace=True)
                 self.feature_1, self.feature_2 = feature_importance.keys()[0], feature_importance.keys()[1]
             else:

diff --git a/deepchecks/suites/distribution_suite.py b/deepchecks/suites/distribution_suite.py
@@ -11,7 +11,6 @@
 """The predefined Data Distribution suite module."""
 from deepchecks import Suite
 from deepchecks.checks.distribution import TrainTestDrift
-from deepchecks.checks.distribution import TrustScoreComparison
 
 
 def data_distribution_suite() -> Suite:
@@ -22,5 +21,4 @@ def data_distribution_suite() -> Suite:
     return Suite(
         'Data Distribution',
         TrainTestDrift().add_condition_drift_score_not_greater_than(),
-        TrustScoreComparison().add_condition_mean_score_percent_decline_not_greater_than()
     )
diff --git a/deepchecks/suites/integrity_suite.py b/deepchecks/suites/integrity_suite.py
@@ -19,7 +19,6 @@
     SpecialCharacters,
     StringMismatchComparison,
     CategoryMismatchTrainTest,
-    NewLabelTrainTest,
     RareFormatDetection,
     DominantFrequencyChange,
     StringLengthOutOfBounds,
@@ -63,7 +62,6 @@ def comparative_integrity_suite() -> Suite:
         StringMismatchComparison().add_condition_no_new_variants(),
         CategoryMismatchTrainTest().add_condition_new_categories_not_greater_than(),
         DominantFrequencyChange().add_condition_ratio_of_change_not_more_than(),
-        NewLabelTrainTest().add_condition_new_labels_not_greater_than()
     )
 
 

diff --git a/deepchecks/suites/performance_suite.py b/deepchecks/suites/performance_suite.py
@@ -10,7 +10,7 @@
 #
 """The predefined performance suite module."""
 from deepchecks import Suite
-from deepchecks.checks import TrustScoreComparison
+from deepchecks.checks import TrustScoreComparison, NewLabelTrainTest
 from deepchecks.checks.performance import (
     PerformanceReport,
     ConfusionMatrixReport,
@@ -43,7 +43,8 @@ def classification_suite() -> Suite:
         RocReport().add_condition_auc_not_less_than(),
         CalibrationMetric(),
         TrustScoreComparison().add_condition_mean_score_percent_decline_not_greater_than(),
-        ClassPerformanceImbalance().add_condition_ratio_difference_not_greater_than()
+        ClassPerformanceImbalance().add_condition_ratio_difference_not_greater_than(),
+        NewLabelTrainTest().add_condition_new_labels_not_greater_than()
     )