Skip to content

Commit

Permalink
fixing notebook detection (#205)
Browse files Browse the repository at this point in the history
* fixing notebook detection

* fixing ipynb detection
  • Loading branch information
ItayGabbay committed Nov 30, 2021
1 parent c6f79e4 commit 495ae40
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 3 deletions.
4 changes: 2 additions & 2 deletions deepchecks/utils/ipython.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ def is_notebook() -> bool:
True if we are in a notebook context, False otherwise
"""
try:
shell = get_ipython().__class__.__name__
return shell == 'ZMQInteractiveShell'
shell = get_ipython()
return hasattr(shell, 'config')
except NameError:
return False # Probably standard Python interpreter

Expand Down
8 changes: 7 additions & 1 deletion docs/index.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
You can adapt this file completely to your liking, but it should at least
contain the root `toctree` directive.
Welcome to mlchecks's documentation!
Welcome to Deepchecks' documentation!
====================================

.. toctree::
Expand All @@ -14,7 +14,13 @@ Welcome to mlchecks's documentation!
:maxdepth: 2
:caption: Docstring

Reference Guides
================

.. toctree::
:maxdepth: 1

deepcheckss/deepchecks.rst

Indices and tables
==================
Expand Down

0 comments on commit 495ae40

Please sign in to comment.