Skip to content

Commit

Permalink
fixing comments
Browse files Browse the repository at this point in the history
  • Loading branch information
ItayGabbay committed Dec 6, 2021
1 parent 9c42e5c commit 569531d
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions makefile
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ REQUIREMENTS_LOG := .requirements.log
ANALIZE_PKGS = pylint pydocstyle
TEST_CODE := tests/
TEST_RUNNER_PKGS = pytest pytest-cov pyhamcrest nbval
NOTEBOOK_DIR = ./notebooks/checks
NB_EXAMPLES = ./notebooks/examples/**/*.ipynb
NOTEBOOK_CHECKS = ./notebooks/checks
NOTEBOOK_EXAMPLES = ./notebooks/examples/**/*.ipynb
NOTEBOOK_SANITIZER_FILE= ./notebooks/.nbval-sanitizer

PYLINT_LOG = .pylint.log
Expand Down Expand Up @@ -136,8 +136,8 @@ notebook: $(REQUIREMENTS_LOG) $(TEST_RUNNER)
# deepchecks in development mode
$(PIP) install --no-deps -e .
# Making sure the examples are running, without validating their outputs.
$(JUPYTER) nbconvert --execute $(NB_EXAMPLES) --to notebook --stdout > /dev/null
$(pythonpath) $(TEST_RUNNER) --nbval $(NOTEBOOK_DIR) --sanitize-with $(NOTEBOOK_SANITIZER_FILE)
$(JUPYTER) nbconvert --execute $(NOTEBOOK_EXAMPLES) --to notebook --stdout > /dev/null
$(pythonpath) $(TEST_RUNNER) --nbval $(NOTEBOOK_CHECKS) --sanitize-with $(NOTEBOOK_SANITIZER_FILE)
$(TEST_RUNNER):
$(PIP) install $(TEST_RUNNER_PKGS) | tee -a $(REQUIREMENTS_LOG)

Expand Down Expand Up @@ -298,7 +298,7 @@ download:
$(PIP) install $(PROJECT)

jupyter: $(JUPYTER)
$(BIN)/jupyter-notebook $(args) --notebook-dir=$(NOTEBOOK_DIR)
$(BIN)/jupyter-notebook $(args) --notebook-dir=$(NOTEBOOK_CHECKS)

$(JUPYTER):
$(PIP) install jupyter

0 comments on commit 569531d

Please sign in to comment.