Skip to content

Commit

Permalink
Small typos fixes (#487)
Browse files Browse the repository at this point in the history
  • Loading branch information
nirhutnik committed Jan 4, 2022
1 parent 31018fa commit ca7866b
Show file tree
Hide file tree
Showing 4 changed files with 610 additions and 538 deletions.
6 changes: 3 additions & 3 deletions deepchecks/checks/performance/performance_report.py
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ def condition(check_result: pd.DataFrame):
not_passed = check_result.loc[check_result['Value'] < min_score]
not_passed_test = check_result.loc[check_result['Dataset'] == 'Test']
if len(not_passed):
details = f'Scores that did not passed the threshold:<br>' \
details = f'Scores that did not pass the threshold:<br>' \
f'{not_passed_test[["Class", "Metric", "Value"]].to_dict("records")}'
return ConditionResult(False, details)
return ConditionResult(True)
Expand Down Expand Up @@ -206,7 +206,7 @@ def condition(check_result: pd.DataFrame) -> ConditionResult:
failed_scores = [k for k, v in diff.items() if v > threshold]
if failed_scores:
for score_name in failed_scores:
explained_failures.append(f'{score_name} on class {class_name} '
explained_failures.append(f'{score_name} for class {class_name} '
f'(train={format_number(train_scores_dict[score_name])} '
f'test={format_number(test_scores_dict[score_name])})')
else:
Expand All @@ -227,7 +227,7 @@ def condition(check_result: pd.DataFrame) -> ConditionResult:
else:
return ConditionResult(True)

return self.add_condition(f'Train-Test scores degradation ratio is not greater than {threshold}',
return self.add_condition(f'Train-Test scores relative degradation is not greater than {threshold}',
condition)

def add_condition_class_performance_imbalance_ratio_not_greater_than(
Expand Down
40 changes: 16 additions & 24 deletions examples/checks/performance/performance_report.ipynb

Large diffs are not rendered by default.

0 comments on commit ca7866b

Please sign in to comment.