Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] Adding text properties (3) #2524

Closed
hjain5164 opened this issue May 11, 2023 · 1 comment · Fixed by #2536
Closed

[FEAT] Adding text properties (3) #2524

hjain5164 opened this issue May 11, 2023 · 1 comment · Fixed by #2536
Assignees
@hjain5164
Labels
feature Feature update or code change to the package linear nlp Affects deepchecks.nlp package

Comments

@hjain5164
Copy link
Contributor

hjain5164 commented May 11, 2023 •
edited

Is your feature request related to a problem? Please describe.
As discussed with @Nadav-Barak, the following text properties can be added but will not be the under the default text properties.

  • Count the number of unique URLs in the text.
  • Count the number of unique emails in the text.
  • Count the number of unique syllables in the text.
  • Average number of syllables in the text (not necessarily unique). Since the average number of syllables per sentence makes more sense.
  • Calculate the reading time of the text in seconds.
  • Count the number of unique date-times in the text. Let us do it later since this is not much useful for now.
  • Calculate the number of sentences in the text.
  • Calculate the average number of syllables per sentence in each text.

Describe the solution you'd like
Will be adding the above properties in the text_properties.py file. If the user wants to calculate these properties, then he can. These properties will not be calculated by default.

Describe alternatives you've considered
Discussed multiple properties and decided to go with this.
@github-actions github-actions bot added needs triage Issue needs to be labeled and prioritized linear labels May 11, 2023
@hjain5164
Copy link
Contributor Author

@Nadav-Barak or @noamzbr Can anyone assign this to me?

@hjain5164 hjain5164 mentioned this issue May 15, 2023
Merged
@Nadav-Barak Nadav-Barak added feature Feature update or code change to the package nlp Affects deepchecks.nlp package and removed needs triage Issue needs to be labeled and prioritized labels May 16, 2023
noamzbr added a commit that referenced this issue May 21, 2023
@hjain5164 @noamzbr
Fixes #2524 Refactoring of the calculate_default_properties function …
a1f921e 
…and adding new text properties (#2536)

* Refactoring of the calculate_default_properties function and adding new properties
---------

Co-authored-by: Noam Bressler <noamzbr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hjain5164 hjain5164

Labels
feature Feature update or code change to the package linear nlp Affects deepchecks.nlp package
Projects
None yet
Milestone
No milestone
2 participants
@hjain5164 @Nadav-Barak