Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add test to conditions in class performance check #1087

Merged
merged 1 commit into from Mar 23, 2022
Merged

add test to conditions in class performance check #1087

merged 1 commit into from Mar 23, 2022

Conversation

benisraeldan
Copy link
Contributor

Reference Issues/PRs

resolve #1054

What does this implement/fix? Explain your changes.

Add more tests to class performance check. conditions tests were missing

Any other comments?

Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/deepchecks/deepchecks/blob/main/CONTRIBUTING.rst

@benisraeldan benisraeldan self-assigned this Mar 22, 2022
@ItayGabbay ItayGabbay added the feature Feature update or code change to the package label Mar 23, 2022
@matanper matanper merged commit e95572e into main Mar 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the dc-1054-class-performance-tests branch March 23, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItayGabbay ItayGabbay ItayGabbay approved these changes

@JKL98ISR JKL98ISR Awaiting requested review from JKL98ISR

Assignees

@benisraeldan benisraeldan

Labels
feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] [CV] Add testing to class performance
3 participants
@benisraeldan @ItayGabbay @matanper