Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor for labels & image outlier #1091

Merged
merged 8 commits into from Mar 23, 2022
Merged

Conversation

matanper
Copy link
Contributor

@matanper matanper commented Mar 23, 2022

Before implementing label & image outliers checks, I needed a few changes:

  1. easy way to get for the samples I run on the real dataset index. Will now be able to do in the update:
properties_with_id = []
for index, image in enumarte(batch.images):
  property = func(image)
  dataset_index = batch.get_index_in_dataset(index)
  properties_with_id += [(dataset_index, property)]
  1. Made label & prediction properties to either return flat list or list of lists
  2. Made it possible to run checks on VisionData classes that don't have labels. Until now it would have raised exception when trying to update the VisionData cache, so added try/except

@matanper matanper added the refactoring Making significant changes to structure of code label Mar 23, 2022
@matanper matanper self-assigned this Mar 23, 2022
@matanper matanper changed the title Refactor for labels outlier Refactor for labels & image outlier Mar 23, 2022
@matanper matanper enabled auto-merge (squash) March 23, 2022 11:47
@matanper matanper disabled auto-merge March 23, 2022 11:47
@JKL98ISR
Copy link
Member

also other functions missing type hints i.e get_index_in_dataset

@matanper matanper merged commit a68b10a into main Mar 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the refactor-for-labels-outlier branch March 23, 2022 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Making significant changes to structure of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants