New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prediction drift to tabular #1105
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benisraeldan
requested review from
a team,
ItayGabbay and
shir22
as code owners
March 24, 2022 14:13
noamzbr
reviewed
Mar 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please attach the pdf / html generated by plot_train_test_prediction_drift
deepchecks/tabular/checks/distribution/train_test_prediction_drift.py
Outdated
Show resolved
Hide resolved
deepchecks/tabular/checks/distribution/train_test_prediction_drift.py
Outdated
Show resolved
Hide resolved
docs/source/examples/tabular/checks/distribution/source/plot_train_test_prediction_drift.py
Outdated
Show resolved
Hide resolved
docs/source/examples/tabular/checks/distribution/source/plot_train_test_prediction_drift.py
Outdated
Show resolved
Hide resolved
docs/source/examples/tabular/checks/distribution/source/plot_train_test_prediction_drift.py
Outdated
Show resolved
Hide resolved
docs/source/examples/tabular/checks/distribution/source/plot_train_test_prediction_drift.py
Outdated
Show resolved
Hide resolved
docs/source/examples/tabular/checks/distribution/source/plot_train_test_prediction_drift.py
Outdated
Show resolved
Hide resolved
docs/source/examples/tabular/checks/distribution/source/plot_train_test_prediction_drift.py
Outdated
Show resolved
Hide resolved
JKL98ISR
reviewed
Mar 27, 2022
noamzbr
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example can be improved to be more interesting, but it's not a must.
ItayGabbay
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
resovles #803
What does this implement/fix? Explain your changes.
Adds a new check
TrainTestPredictionDrift
that checks drift on the model predictions.Any other comments?
fixed some links in the documentation
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/deepchecks/deepchecks/blob/main/CONTRIBUTING.rst