Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prediction drift to tabular #1105

Merged
merged 9 commits into from Mar 28, 2022
Merged

Conversation

benisraeldan
Copy link
Contributor

Reference Issues/PRs

resovles #803

What does this implement/fix? Explain your changes.

Adds a new check TrainTestPredictionDrift that checks drift on the model predictions.

Any other comments?

fixed some links in the documentation


Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/deepchecks/deepchecks/blob/main/CONTRIBUTING.rst

@benisraeldan benisraeldan requested review from a team, ItayGabbay and shir22 as code owners March 24, 2022 14:13
@benisraeldan benisraeldan self-assigned this Mar 24, 2022
@benisraeldan benisraeldan added the feature Feature update or code change to the package label Mar 24, 2022
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please attach the pdf / html generated by plot_train_test_prediction_drift

@benisraeldan
Copy link
Contributor Author

Screen Shot 2022-03-27 at 18 53 52

Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example can be improved to be more interesting, but it's not a must.

@benisraeldan benisraeldan enabled auto-merge (squash) March 28, 2022 16:43
@benisraeldan benisraeldan merged commit ef7ffa3 into main Mar 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the dc-803-train-test-prediction-drift branch March 28, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature update or code change to the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants