Sending anonymous analytics #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shir22
reviewed
Apr 6, 2022
| @@ -0,0 +1,30 @@ | |||
| """Module for anonymous analytics tracking.""" | |||
There was a problem hiding this comment.
add here another sentence clarifying the same as inside the documentation...
(no personal data etc. will ever be sent. only a single event upon import)
matanper
reviewed
Apr 6, 2022
| @@ -90,3 +90,17 @@ Start Working with the Package | |||
| Now it's time to :doc:`check out </index>` deepchecks! | |||
|
|
|||
|
|
|||
| Anonymous Usage Metrics | |||
There was a problem hiding this comment.
I think the name telemetry is more common in this cases
matanper
reviewed
Apr 6, 2022
deepchecks/__init__.py
Outdated
| try: | ||
| disable = os.environ.get('DEEPCHECKS_DISABLE_LATEST', 'false').lower() == 'true' | ||
| disable = os.environ.get('DISABLE_DEEPCHECKS_ANONYMOUS_TRACKING', False) |
There was a problem hiding this comment.
there is already if disabled inside the function
Suggested change
| disable = os.environ.get('DISABLE_DEEPCHECKS_ANONYMOUS_TRACKING', False) | |
| send_anonymous_import_event() |
matanper
approved these changes
Apr 7, 2022
matanper
approved these changes
Apr 7, 2022
shir22
approved these changes
Apr 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Any other comments?
Thanks for contributing a pull request! Please ensure you have taken a look at
the contribution guidelines: https://github.com/deepchecks/deepchecks/blob/main/CONTRIBUTING.rst