Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve performance_report notebook #1271

Merged
merged 3 commits into from Apr 14, 2022

Conversation

benisraeldan
Copy link
Contributor

Reference Issues/PRs

Resolves #656

@benisraeldan benisraeldan added the documentation modification of the documentation / readme's label Apr 13, 2022
@benisraeldan benisraeldan self-assigned this Apr 13, 2022
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor comment

This check helps you compare your model's performance between two datasets.
The default metric that are used are F1, Percision, and Recall for Classification
and Negative Root Mean Square Error, Negative Mean Absolute Error, and R2 for Regression. RMSE and MAE Scorers are
negative because we subscribe to the convention of sklearn to evaluate a model.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
negative because we subscribe to the convention of sklearn to evaluate a model.
negative because we subscribe to the sklearn convention of defining scoring functions

@benisraeldan benisraeldan marked this pull request as ready for review April 14, 2022 08:24
@benisraeldan benisraeldan requested a review from a team as a code owner April 14, 2022 08:24
@benisraeldan benisraeldan enabled auto-merge (squash) April 14, 2022 08:30
@benisraeldan benisraeldan merged commit 00fceed into main Apr 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the dc-656-performance-report-notebook branch April 14, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation modification of the documentation / readme's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Improve Performance Report (Performance) notebook
2 participants