Nb/tabular/increase speed outlier detection + timeout #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noamzbr
reviewed
May 11, 2022
deepchecks/tabular/checks/integrity/outlier_sample_detection.py
Outdated
Show resolved
Hide resolved
deepchecks/tabular/checks/integrity/outlier_sample_detection.py
Outdated
Show resolved
Hide resolved
| @@ -88,3 +57,26 @@ def test_mix_columns_full_matrix_with_nulls(): | |||
| assert_that(dist[-1], has_length(data.shape[0])) | |||
| assert_that(dist[3], has_item(greater_than(0.01))) | |||
| assert_that(min(dist[0]), less_than_or_equal_to(0)) | |||
|
|
|||
|
|
|||
| def test_mix_columns_nn_matrix_with_nulls_vectorized(): | |||
There was a problem hiding this comment.
Good idea, are gowers dependencies OK?
There was a problem hiding this comment.
The dependencies were only added to dev-requirements so as far i understood are not downloaded with the package, am I correct? @matanper
There was a problem hiding this comment.
Yep it's right, just making sure that the testing env will be functional.
docs/source/checks/tabular/integrity/plot_outlier_sample_detection.py
Outdated
Show resolved
Hide resolved
|
Re-add the check to the integrity suite. |
|
Already added |
ItayGabbay
approved these changes
May 11, 2022
…/Tabular/increase_speed_oulier_detection
…_detection' into NB/Tabular/increase_speed_oulier_detection
delete-merged-branch
bot
deleted the
NB/Tabular/increase_speed_oulier_detection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major increase in running speed due to vectorization and other cool numpy tricks + Added a timeout mechanism.
It is still not that fast (7 sec for 10K samples with dimension 13).