New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple feature fixes #1419
Simple feature fixes #1419
Conversation
@@ -180,7 +174,7 @@ def mnist_batch_to_images_with_bias(batch): | |||
|
|||
#%% | |||
|
|||
check = SimpleFeatureContribution() | |||
check = SimpleFeatureContribution(per_class=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But... you just reverted the doc to use the per_class=False. But we do want to show the per_class=True feature. We actually want to show both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it has both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mnist is per class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
test_df: pd.DataFrame, | ||
test_label_name: Optional[Hashable], ppscore_params: dict, | ||
n_show_top: int, | ||
min_pps_to_show: float = 0.05, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You didn't add min_pps_to_show to the check's parameters...
To this one or to single feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i added to simple feature, should i add to single too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think so. Also missed that it was added to the check, sorry
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
|
closes #1004
docs have now example per class and per all. added min pps to init + test
also fixed not showing negative difference in the condition (if train < test)