[BUGFIX] Serialization logic - additional fixes. #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…display api unification;
JKL98ISR
requested changes
May 11, 2022
JKL98ISR
reviewed
May 11, 2022
JKL98ISR
approved these changes
May 11, 2022
JKL98ISR
requested changes
May 11, 2022
| if file is None: | ||
| file = 'output.html' | ||
| if isinstance(file, str): | ||
| file = create_new_file_name(file) | ||
|
|
||
| if as_widget is True: | ||
| widget_to_html( | ||
| widget=self.to_widget(unique_id=output_id), | ||
| widget=self.to_widget(unique_id=unique_id or get_random_string(n=25)), |
There was a problem hiding this comment.
previously output_id was declared above if file is None: now I just replaced it with one statement/
it means that if a user did not pass a unique_id we need to generate it by ourselves in order to make sure that navigation links will be rendered
JKL98ISR
approved these changes
May 12, 2022
JKL98ISR
approved these changes
May 12, 2022
JKL98ISR
requested changes
May 12, 2022
JKL98ISR
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1392 but contains much more modifications
List of changes:
== 1 ==
added a new type of serialization protocol, called
IPythonSerializer.Serializers that implement this kind of protocol must return a list of objects that implements
IPython.core.formatterstraits.For more info please refer to the IPython documentation
We need this type of protocol in order to make sure that the check/suite result display works properly in different environments like JupyterLab/Classical Notebooks, especially when widgets are not enabled or not supported.
== 2 ==
added
display_check,show,save_as_htmlmethods to theCheckFailuretype.== 3 ==
now, 'Widgets UI' is also used in the colab env.