Cramers v #1446
Merged
Cramers v #1446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirhutnik
reviewed
May 16, 2022
deepchecks/tabular/checks/distribution/train_test_feature_drift.py
Outdated
Show resolved
Hide resolved
deepchecks/tabular/checks/distribution/train_test_feature_drift.py
Outdated
Show resolved
Hide resolved
deepchecks/tabular/checks/distribution/train_test_label_drift.py
Outdated
Show resolved
Hide resolved
deepchecks/tabular/checks/distribution/train_test_label_drift.py
Outdated
Show resolved
Hide resolved
deepchecks/vision/checks/distribution/train_test_label_drift.py
Outdated
Show resolved
Hide resolved
tests/vision/checks/distribution/train_test_prediction_drift_test.py
Outdated
Show resolved
Hide resolved
nirhutnik
reviewed
May 16, 2022
deepchecks/tabular/checks/distribution/train_test_feature_drift.py
Outdated
Show resolved
Hide resolved
nirhutnik
approved these changes
May 16, 2022
matanper
approved these changes
May 16, 2022
| @@ -107,6 +117,7 @@ def __init__( | |||
| else: | |||
| raise DeepchecksValueError('sort_feature_by must be either "feature importance" or "drift score"') | |||
| self.n_top_columns = n_top_columns | |||
| self.categorical_drift_method = categorical_drift_method | |||
There was a problem hiding this comment.
maybe validate the value in the init?
There was a problem hiding this comment.
in similar cases we also don't check on init so I don't think this case should be an exception
ItayGabbay
approved these changes
May 16, 2022
|
Approved the docs part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1272