New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactoring] resolved some TODOs
items from the source code
#1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yromanyshyn
added
the
refactoring
Making significant changes to structure of code
label
May 23, 2022
@JKL98ISR can you review? |
JKL98ISR
reviewed
May 25, 2022
JKL98ISR
reviewed
May 25, 2022
note regarding I marked example import wandb
r1 = wandb.init(project='test1')
r2 = wandb.init(project='test2')
print(wandb.run is r2) # True
r2.log({'accuraccy': 0.8})
r2.finish()
print(wandb.run is None) # True
r1.log({'accuraccy': 0.8}) # << will raise "Exception: The wandb backend process has shutdown" so, now |
JKL98ISR
reviewed
May 26, 2022
JKL98ISR
approved these changes
May 26, 2022
noamzbr
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved some
TODOs
from the source codelist of changes:
SuiteResult
constructorwith_display
parameter (CheckFailure.to_json
,SuiteResult.to_json
)