Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue-1448] IsSingleValue check - ignore nan #1522

Merged
merged 12 commits into from May 30, 2022
Merged

[issue-1448] IsSingleValue check - ignore nan #1522

merged 12 commits into from May 30, 2022

Conversation

yromanyshyn
Copy link
Contributor

resolves #1448

@yromanyshyn yromanyshyn added the feature Feature update or code change to the package label May 27, 2022
@yromanyshyn yromanyshyn requested review from a team as code owners May 27, 2022 13:26
@yromanyshyn yromanyshyn self-assigned this May 27, 2022
noamzbr
noamzbr reviewed May 29, 2022
View reviewed changes
Copy link
Collaborator

@noamzbr noamzbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add an example of this option to plot_is_single_value.py

deepchecks/tabular/checks/data_integrity/is_single_value.py Outdated Show resolved Hide resolved
matanper
matanper suggested changes May 29, 2022
View reviewed changes
Copy link
Contributor

@matanper matanper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notice that line uniques = df.loc[:, cols_with_single].head(1)
it won't work currently, since it just takes the first value (which might be null)

@yromanyshyn yromanyshyn requested a review from shir22 as a code owner May 30, 2022 07:28
@yromanyshyn
Copy link
Contributor Author

@matanper

notice that line uniques = df.loc[:, cols_with_single].head(1)
it won't work currently, since it just takes the first value (which might be null)

nice catch, thanks!
fixed

@yromanyshyn
Copy link
Contributor Author

@noamzbr

Please also add an example of this option to plot_is_single_value.py

added

@yromanyshyn yromanyshyn enabled auto-merge (squash) May 30, 2022 11:14
@yromanyshyn yromanyshyn requested a review from matanper May 30, 2022 11:14
@yromanyshyn yromanyshyn merged commit b4b620c into main May 30, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue-1448 branch May 30, 2022 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanper matanper matanper approved these changes

@ItayGabbay ItayGabbay ItayGabbay approved these changes

@shir22 shir22 Awaiting requested review from shir22 shir22 is a code owner

@noamzbr noamzbr Awaiting requested review from noamzbr noamzbr is a code owner

Assignees

@yromanyshyn yromanyshyn

Labels
feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Enable ignoring Null values in the Is Single Value check
4 participants
@yromanyshyn @matanper @noamzbr @ItayGabbay