Static vision model #1525
Merged
Static vision model #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanper
approved these changes
May 29, 2022
| @@ -75,13 +89,19 @@ def __getitem__(self, index: int): | |||
|
|
|||
| def __len__(self): | |||
| """Return length of batch.""" | |||
| return len(self._batch) | |||
| dataset = self._context.get_data_by_kind(self._dataset_kind) | |||
There was a problem hiding this comment.
I'm not sure this is the best way to get batch length, maybe we should use len(batch_to_images(batch))
@noamzbr WDYT?
There was a problem hiding this comment.
batch_to_images not always implemented.
fixed case of sampled data
ItayGabbay
approved these changes
May 29, 2022
noamzbr
reviewed
May 30, 2022
| @@ -75,13 +90,19 @@ def __getitem__(self, index: int): | |||
|
|
|||
| def __len__(self): | |||
| """Return length of batch.""" | |||
| return len(self._batch) | |||
| dataset = self._context.get_data_by_kind(self._dataset_kind) | |||
There was a problem hiding this comment.
@JKL98ISR Can you explain the logic of this code? Possible also in comments.
Seems to me like this returns the number of batches in the dataset.
There was a problem hiding this comment.
it returns the length of the batch.
dataloader_len is the amount of batches the dataloader has
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1364
also fixed batch length bug