New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor all conditions naming #1583
Merged
matanper
merged 10 commits into
main
from
1339-feat-change-condition-wording-to-not-have-double-negation
Jun 7, 2022
Merged
Refactor all conditions naming #1583
matanper
merged 10 commits into
main
from
1339-feat-change-condition-wording-to-not-have-double-negation
Jun 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matanper
added
refactoring
Making significant changes to structure of code
and removed
feature
Feature update or code change to the package
labels
Jun 7, 2022
noamzbr
reviewed
Jun 7, 2022
deepchecks/tabular/checks/data_integrity/feature_label_correlation.py
Outdated
Show resolved
Hide resolved
deepchecks/tabular/checks/data_integrity/outlier_sample_detection.py
Outdated
Show resolved
Hide resolved
deepchecks/tabular/checks/data_integrity/outlier_sample_detection.py
Outdated
Show resolved
Hide resolved
deepchecks/tabular/checks/data_integrity/string_length_out_of_bounds.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
matanper
changed the title
Refactor integrity conditions naming
Refactor all conditions naming
Jun 7, 2022
ItayGabbay
reviewed
Jun 7, 2022
deepchecks/tabular/checks/model_evaluation/regression_error_distribution.py
Outdated
Show resolved
Hide resolved
ItayGabbay
approved these changes
Jun 7, 2022
delete-merged-branch
bot
deleted the
1339-feat-change-condition-wording-to-not-have-double-negation
branch
June 7, 2022 22:53
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.