Add passed function to suite result #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKL98ISR
approved these changes
Jun 9, 2022
Nadav-Barak
reviewed
Jun 9, 2022
deepchecks/core/check_result.py
Outdated
| @@ -161,9 +161,9 @@ def have_display(self) -> bool: | |||
| """Return if this check has display.""" | |||
| return bool(self.display) | |||
|
|
|||
| def passed_conditions(self) -> bool: | |||
| def passed_conditions(self, fail_on_warning=True) -> bool: | |||
There was a problem hiding this comment.
IMO fail on warning should be default False
| return self.select_results(self.failures) | ||
|
|
||
| def get_checks_not_passed(self, fail_on_warning=True) -> List[CheckResult]: | ||
| """Get all the check results that have not passing condition. |
There was a problem hiding this comment.
Not sure about this devision, where do checks without conditions go?
Maybe do this in the same devision as the new suite output: pass, fail, didnt run, other(/ checks without conditions)
There was a problem hiding this comment.
this division is just for the passed function, checks without condition are not relevant
added 3 commits
June 9, 2022 17:42
shir22
approved these changes
Jun 12, 2022
ItayGabbay
approved these changes
Jun 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1591
resolve #1589