Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static drift tv #162

Merged
merged 35 commits into from
Nov 29, 2021
Merged

Static drift tv #162

merged 35 commits into from
Nov 29, 2021

Conversation

nirhutnik
Copy link
Contributor

No description provided.

noamzbr
noamzbr reviewed Nov 21, 2021
View reviewed changes
deepchecks/checks/drift/train_test_drift.py Outdated Show resolved Hide resolved
deepchecks/checks/drift/train_test_drift.py Outdated Show resolved Hide resolved
deepchecks/checks/drift/train_test_drift.py Outdated Show resolved Hide resolved
deepchecks/checks/drift/train_test_drift.py Outdated Show resolved Hide resolved
deepchecks/checks/drift/train_test_drift.py Outdated Show resolved Hide resolved
nirhutnik and others added 19 commits November 21, 2021 10:50
@nirhutnik @noamzbr
Update deepchecks/checks/drift/train_test_drift.py
c5e6609 
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
@nirhutnik @noamzbr
Update deepchecks/checks/drift/train_test_drift.py
495193c 
Co-authored-by: Noam Bressler <noamzbr@gmail.com>
@nirchecks
changed docstring
c8049d7
@nirchecks
Merge remote-tracking branch 'origin/static_drift_tv' into static_dri…
486fe8f 
…ft_tv
@nirchecks
Merge branch 'master' into static_drift_tv
89000e2
@nirchecks
Added condition
68235ee
@nirchecks
Fixed displays -
6d88159 
order by importance or score
add colorbar to graphs to indicate score
@noamzbr
Merge branch 'main' into static_drift_tv
95c33f1
@noamzbr
improve color bar and cat plot
b8d81be
@noamzbr
Merge branch 'main' into static_drift_tv
a8b33a2
@noamzbr
improve color bar and cat plot, add drift suite
af5aa55
@noamzbr
Merge branch 'main' into static_drift_tv
9fba991
@noamzbr
Merge branch 'main' into static_drift_tv
39a9fc2 
# Conflicts:
#	deepchecks/checks/drift/__init__.py
@noamzbr
improve display
00469c4
@noamzbr
improve display & add tests
097ab1e
@noamzbr
pylint and docs fixes
1f838ad
@noamzbr
Merge branch 'main' into static_drift_tv
9f17e97
@noamzbr
pylint, docs & nb fixes
d32e768
@noamzbr
minor refactor for new pylint rule
d20038b
@noamzbr
small fixes
0d5e616
@noamzbr
Merge branch 'main' into static_drift_tv
2592124 
# Conflicts:
#	notebooks/examples/CheckSuite_Iris_Dataset.ipynb
#	notebooks/examples/basic/simple integrity demo.ipynb
#	tests/suites/test_suites.py
@noamzbr
update suites
f1efe7e
ItayGabbay
ItayGabbay previously approved these changes Nov 29, 2021
View reviewed changes
Copy link
Contributor

@ItayGabbay ItayGabbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. I trust you that the drift logic is correct

noamzbr
noamzbr previously approved these changes Nov 29, 2021
View reviewed changes
noamzbr
noamzbr previously approved these changes Nov 29, 2021
View reviewed changes
@noamzbr noamzbr merged commit eabd8fb into main Nov 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the static_drift_tv branch November 29, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanper matanper matanper left review comments

@shir22 shir22 shir22 left review comments

@noamzbr noamzbr noamzbr approved these changes

@ItayGabbay ItayGabbay ItayGabbay left review comments

Assignees

@nirhutnik nirhutnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nirhutnik @matanper @noamzbr @ItayGabbay @shir22 @nirchecks