Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick start model evaluation + new dataset #1726

Merged
merged 50 commits into from Jul 7, 2022
Merged

Conversation

Nadav-Barak
Copy link
Collaborator

@Nadav-Barak Nadav-Barak commented Jul 5, 2022

Fixed imports that created deprecation warnings
Added a new data set to package
See attached pdf for QuickStart guide
Quickstart - Model Evaluation Suitev4 — gallery-boilerplate documentation.pdf

Nadav-Barak and others added 30 commits June 20, 2022 18:12
Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
# Conflicts:
#	deepchecks/tabular/suites/default_suites.py
#	deepchecks/utils/performance/partition.py
@Nadav-Barak Nadav-Barak requested review from a team, ItayGabbay and shir22 as code owners July 5, 2022 14:37
@Nadav-Barak Nadav-Barak added documentation modification of the documentation / readme's ds Tasks suited for Data Scientists labels Jul 5, 2022
@Nadav-Barak Nadav-Barak self-assigned this Jul 5, 2022
# * :doc:`/checks_gallery/tabular/model_evaluation/plot_boosting_overfit` check
# and the :doc:`/checks_gallery/tabular/model_evaluation/plot_unused_features` check results implies that the
# model has a well calibrating boosting stopping rule and that it make good use on the different data features.
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add here in one sentence about the other sections?
(that the "Other" is for checks that didn't have conditions on them etc.?)

Comment on lines +22 to +26
# Before we start, if you don't have deepchecks installed yet, run:
import sys
!{sys.executable} -m pip install deepchecks -U --quiet

# or install using pip from your python environment
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Before we start, if you don't have deepchecks installed yet, run:
import sys
!{sys.executable} -m pip install deepchecks -U --quiet
# or install using pip from your python environment
# Before we start, if you don't have deepchecks installed yet, run:
import sys
!{sys.executable} -m pip install deepchecks -U --quiet
# or install using pip from your python environment

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with/without newline between both (no preference but I think more aesthetic if similar)

Co-authored-by: shir22 <33841818+shir22@users.noreply.github.com>
@ItayGabbay ItayGabbay merged commit eef382e into main Jul 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the NB/Feat/wine_quality_ds branch July 7, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation modification of the documentation / readme's ds Tasks suited for Data Scientists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants