Image property outliers display when there are no outliers #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay and test the case of black and white
noamzbr
reviewed
Jul 6, 2022
| display.append(html) | ||
| grouped = no_outliers.groupby(level=0).unique().str.join(', ') | ||
| grouped_df = pd.DataFrame(grouped, columns=['Properties']) | ||
| grouped_df['Reason'] = grouped_df.index |
There was a problem hiding this comment.
@shir22 Any idea for a better name than "Reason"?
There was a problem hiding this comment.
Suggestion:
- Rename the "Properties Without Outliers" to - "Properties With No Outliers Found"
- Swap order (properties list in the index/first column and the "why" in the following column)
- Ideas for alternative titles to "Reason" (not sure if they're better): More Info / Outlier Detection Results
There was a problem hiding this comment.
@shir22 I think that the "why" should be on the left because it's the grouping rule
matanper
reviewed
Jul 7, 2022
| grouped_df = pd.DataFrame(grouped, columns=['Properties']) | ||
| grouped_df['Reason'] = grouped_df.index | ||
| grouped_df = grouped_df[['Reason', 'Properties']] | ||
| display.append('<h5><b>Properties Without Outliers</h5></b>') |
There was a problem hiding this comment.
maybe missing an if?
if not grouped_df.empty():
display.append('<h5><b>Properties Without Outliers</h5></b>')
display.append(grouped_df.style.hide_index())
There was a problem hiding this comment.
@matanper, correct- fixed it
noamzbr
approved these changes
Jul 7, 2022
delete-merged-branch
bot
deleted the
1656-image-property-outliers-no-outputs-display
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The properties without outliers grouped by the reason for not having outliers.
Headline size for the properties is now smaller than the "additional outputs" title.