Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate gower distance function #1746

Merged
merged 5 commits into from
Jul 10, 2022
Merged

Separate gower distance function #1746

merged 5 commits into from
Jul 10, 2022

Conversation

nirhutnik
Copy link
Contributor

Changed gower distance API - change function name, change inputs to better suite our package, and add functionality to choose which samples the distance will be calculated for.

@nirhutnik nirhutnik added the feature Feature update or code change to the package label Jul 10, 2022
@nirhutnik nirhutnik self-assigned this Jul 10, 2022
@nirhutnik nirhutnik requested review from a team as code owners July 10, 2022 12:13
@nirhutnik nirhutnik added this to the Bernoulli milestone Jul 10, 2022
Nadav-Barak
Nadav-Barak approved these changes Jul 10, 2022
View reviewed changes
Copy link
Contributor

@Nadav-Barak Nadav-Barak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So american of you

@nirhutnik nirhutnik enabled auto-merge (squash) July 10, 2022 12:51
@nirhutnik nirhutnik merged commit acddfdc into main Jul 10, 2022
@delete-merged-branch delete-merged-branch bot deleted the separate_gower_distance_function branch July 10, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKL98ISR JKL98ISR JKL98ISR approved these changes

@Nadav-Barak Nadav-Barak Nadav-Barak approved these changes

Assignees

@nirhutnik nirhutnik

Labels
feature Feature update or code change to the package
Projects
None yet
Milestone
Bernoulli
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nirhutnik @JKL98ISR @Nadav-Barak