Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

small fixes to drift and gower distance #1794

Merged
merged 5 commits into from
Jul 24, 2022
Merged

small fixes to drift and gower distance #1794

merged 5 commits into from
Jul 24, 2022

Conversation

nirhutnik
Copy link
Contributor

Small fixes I encountered -

  1. Gower distance returns iloc indexes and not original indexes
  2. categorical drift comments quote the needed value for "cramer_v" wrong. Also, added the ability to accept slight differences (using lower case instead of upper, and "cramers_v" instead of "cramer_v")

@nirhutnik nirhutnik added the bug label Jul 19, 2022
@nirhutnik nirhutnik added this to the Copernicus milestone Jul 19, 2022
@nirhutnik nirhutnik self-assigned this Jul 19, 2022
@nirhutnik nirhutnik requested review from a team as code owners July 19, 2022 10:20
@nirhutnik nirhutnik enabled auto-merge (squash) July 24, 2022 10:29
@nirhutnik nirhutnik merged commit f63eb25 into main Jul 24, 2022
@delete-merged-branch delete-merged-branch bot deleted the small_fixes branch July 24, 2022 12:18
@nirhutnik
Copy link
Contributor Author

(didn't merge changes to gower distance)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamzbr noamzbr noamzbr approved these changes

Assignees

@nirhutnik nirhutnik

Labels
bug
Projects
None yet
Milestone
Copernicus
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nirhutnik @noamzbr