FI new function for users #1822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added file user_utils.py Created tests Changed exceptions in feature importance calculation
nirhutnik
added
documentation
Nadav-Barak
reviewed
Jul 26, 2022
Nadav-Barak
reviewed
Jul 26, 2022
|
can you give a better name for the pr? |
JKL98ISR
reviewed
Jul 26, 2022
finished dosctring
Added paragraph in feature_importance.rst
JKL98ISR
approved these changes
Jul 26, 2022
Nadav-Barak
approved these changes
Jul 26, 2022
ItayGabbay
approved these changes
Jul 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1757
Added function calculate_feature_importance in new file tabular/user_utils.py for users to use.
Changed the warnings for force_permutation=True so they will fail the process and we won't continue to built-in feature importance.
Added paragraph in feature_importance.rst.
NOTE!
Changed behavior of calculate_feature_importance in features.py - Now if force_permutation=True, and it fails to calculate permutation importance, the function raises an error (previous behavior skipped and tried model built-in importance, which is not intuitive and doesn't make sense IMO).