Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added flag for users to not ignore nulls in categorical columns #1843

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Added flag for users to not ignore nulls in categorical columns #1843

merged 3 commits into from
Jul 28, 2022

Conversation

nirhutnik
Copy link
Contributor

@nirhutnik nirhutnik commented Jul 28, 2022 •
edited

Closes #1842

@nirhutnik
Fixed PSI to use the correct distribution (without nulls)
fdf3d09 
Added flag for users to not ignore nulls for categorical columns
@nirhutnik nirhutnik added the feature Feature update or code change to the package label Jul 28, 2022
@nirhutnik nirhutnik self-assigned this Jul 28, 2022
@nirhutnik nirhutnik requested review from a team as code owners July 28, 2022 14:14
@nirhutnik nirhutnik enabled auto-merge (squash) July 28, 2022 15:02
@nirhutnik nirhutnik merged commit f435317 into main Jul 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the drift_flag_for_cat_nones_1842 branch July 28, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamzbr noamzbr noamzbr approved these changes

Assignees

@nirhutnik nirhutnik

Labels
feature Feature update or code change to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Categorical None handling for drift
3 participants
@nirhutnik @noamzbr @ItayGabbay