Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Put all utility routines within one package. #196

Merged
merged 4 commits into from
Nov 30, 2021
Merged

[Refactoring] Put all utility routines within one package. #196

merged 4 commits into from
Nov 30, 2021

Conversation

yromanyshyn
Copy link
Contributor

@yromanyshyn yromanyshyn commented Nov 26, 2021 •
edited

list of changes:

  • moved all utility routines/modules to 'utils' package;
  • fixed/added type annotations
  • added deepchecks.errors.py module
  • added base exception type DeepchecksBaseError
  • moved DeepchecksValueError into deepchecks.errors.py

@yromanyshyn yromanyshyn added suggestion refactoring Making significant changes to structure of code labels Nov 26, 2021
@yromanyshyn yromanyshyn self-assigned this Nov 26, 2021
@yromanyshyn yromanyshyn merged commit c6f79e4 into main Nov 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the utils-refactoring branch November 30, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanper matanper matanper approved these changes

@noamzbr noamzbr Awaiting requested review from noamzbr

@ItayGabbay ItayGabbay Awaiting requested review from ItayGabbay

Assignees

@yromanyshyn yromanyshyn

Labels
refactoring Making significant changes to structure of code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yromanyshyn @matanper @YuriyRomanyshynUA