New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added documentation for tabular Model Evaluation checks #1999
added documentation for tabular Model Evaluation checks #1999
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great work, thank you so much!
docs/source/checks/tabular/model_evaluation/plot_calibration_score.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_confusion_matrix_report.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_model_inference_time.py
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_model_inference_time.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_regression_error_distribution.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_segment_performance.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_simple_model_comparison.py
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_single_dataset_performance.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_unused_features.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! thanks for you contribution
docs/source/checks/tabular/model_evaluation/plot_calibration_score.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_confusion_matrix_report.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_train_test_performance.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_confusion_matrix_report.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
…erformance_report.py Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
…erformance_report.py Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
…ror_distribution.py Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small fixes and we can get this merged :)
docs/source/checks/tabular/model_evaluation/plot_confusion_matrix_report.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_multi_model_performance_report.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments should also fix the docs-build failing (due to error in unused features) and enable us to merge 🥳
docs/source/checks/tabular/model_evaluation/plot_confusion_matrix_report.py
Outdated
Show resolved
Hide resolved
docs/source/checks/tabular/model_evaluation/plot_unused_features.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution!
* added documentation * Update docs/source/checks/tabular/model_evaluation/plot_model_info.py Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com> * Update docs/source/checks/tabular/model_evaluation/plot_multi_model_performance_report.py Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com> * Update docs/source/checks/tabular/model_evaluation/plot_multi_model_performance_report.py Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com> * Update docs/source/checks/tabular/model_evaluation/plot_regression_error_distribution.py Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com> * fix doc according to authors' comments * added changes according to author's requests * minor fixes Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com> Co-authored-by: shir22 <33841818+shir22@users.noreply.github.com>
Reference Issues/PRs
Fixes #1997
What does this implement/fix? Explain your changes.
added documentation for checks without it.