Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentation for tabular Model Evaluation checks #1999

Merged
merged 12 commits into from Sep 19, 2022

Conversation

DanBasson
Copy link
Contributor

Reference Issues/PRs

Fixes #1997

What does this implement/fix? Explain your changes.

added documentation for checks without it.

@ItayGabbay ItayGabbay added the documentation modification of the documentation / readme's label Sep 10, 2022
Copy link
Contributor

@nirhutnik nirhutnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work, thank you so much!

Copy link
Contributor

@shir22 shir22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! thanks for you contribution

DanBasson and others added 7 commits September 16, 2022 18:45
Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
…erformance_report.py

Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
…erformance_report.py

Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
…ror_distribution.py

Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
Copy link
Contributor

@shir22 shir22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small fixes and we can get this merged :)

Copy link
Contributor

@shir22 shir22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments should also fix the docs-build failing (due to error in unused features) and enable us to merge 🥳

Copy link
Contributor

@shir22 shir22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution!

@shir22 shir22 enabled auto-merge (squash) September 19, 2022 12:41
@shir22 shir22 merged commit e1954e7 into deepchecks:main Sep 19, 2022
shir22 added a commit that referenced this pull request Sep 20, 2022
* added documentation

* Update docs/source/checks/tabular/model_evaluation/plot_model_info.py

Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>

* Update docs/source/checks/tabular/model_evaluation/plot_multi_model_performance_report.py

Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>

* Update docs/source/checks/tabular/model_evaluation/plot_multi_model_performance_report.py

Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>

* Update docs/source/checks/tabular/model_evaluation/plot_regression_error_distribution.py

Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>

* fix doc according to authors' comments

* added changes according to author's requests

* minor fixes

Co-authored-by: Nir Hutnik <92314933+nirhutnik@users.noreply.github.com>
Co-authored-by: shir22 <33841818+shir22@users.noreply.github.com>
@DanBasson DanBasson deleted the doc-tabular-model-evaluation branch September 21, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation modification of the documentation / readme's
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] documentation for all tabular Model Evaluation checks
4 participants