Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static properties enum fix #2032

Merged
merged 3 commits into from Sep 21, 2022
Merged

Static properties enum fix #2032

merged 3 commits into from Sep 21, 2022

Conversation

TheSolY
Copy link
Contributor

@TheSolY TheSolY commented Sep 21, 2022

Use the ENUM in all of the places, before some used the enum and some the value

@TheSolY TheSolY added bug vision Affects deepchecks.vision package labels Sep 21, 2022
@TheSolY TheSolY added this to the Gödel milestone Sep 21, 2022
@TheSolY TheSolY requested review from a team as code owners September 21, 2022 08:08
@TheSolY TheSolY enabled auto-merge (squash) September 21, 2022 08:47
@TheSolY TheSolY merged commit 30b93e3 into main Sep 21, 2022
@delete-merged-branch delete-merged-branch bot deleted the static_properties_enum_fix branch September 21, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noamzbr noamzbr noamzbr approved these changes

@JKL98ISR JKL98ISR JKL98ISR approved these changes

Assignees
No one assigned
Labels
bug vision Affects deepchecks.vision package
Projects
None yet
Milestone
Gödel
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@TheSolY @noamzbr @JKL98ISR